Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for predefined workingsets for search operations #2649

Closed
gayanper opened this issue Aug 30, 2022 · 4 comments · Fixed by #3748
Closed

Support for predefined workingsets for search operations #2649

gayanper opened this issue Aug 30, 2022 · 4 comments · Fixed by #3748

Comments

@gayanper
Copy link
Contributor

gayanper commented Aug 30, 2022

Add support to switch workingset such as "Main Source", "Test Source" for search operations such as

  • Call Hierarchy
  • Type Hierarchy
  • Reference Search
  • Implementation Search
    etc.

A simple implementation would be to introduce a server setting which will define the default workingset, by default this will be empty or include all main and test sources.

Then from the UI we could provide a picker to switch between Main, Test and All which are predefine values. We will show the current workingset in the status bar as well and clicking on that will trigger picker as well.

On the server side this setting will be used in the all Java search queries to define the scope of the search.

Environment
  • Operating System:
  • JDK version: 17
  • Visual Studio Code version: 1.70.2
  • Java extension version: 1.10.0
@gayanper
Copy link
Contributor Author

@jdneo @rgrunber WDYT about this ?

@jdneo
Copy link
Collaborator

jdneo commented Aug 31, 2022

I think the request makes sense. I would prefer including all main and test sources as the default preference.

gayanper added a commit to gayanper/vscode-java that referenced this issue Aug 24, 2024
Provide two scopes to search from for search operations such as
- reference search
- call hierarchy search

Signed-off-by: Gayan Perera <gayanper@gmail.com>
gayanper added a commit to gayanper/vscode-java that referenced this issue Sep 17, 2024
Provide two scopes to search from for search operations such as
- reference search
- call hierarchy search

Signed-off-by: Gayan Perera <gayanper@gmail.com>
@rgrunber rgrunber added this to the End September 2024 milestone Sep 24, 2024
gayanper added a commit to gayanper/vscode-java that referenced this issue Sep 25, 2024
Provide two scopes to search from for search operations such as
- reference search
- call hierarchy search

Signed-off-by: Gayan Perera <gayanper@gmail.com>
@rgrunber
Copy link
Member

@gayanper I don't think we did type hierarchy, right ?

@gayanper
Copy link
Contributor Author

@gayanper I don't think we did type hierarchy, right ?

No @rgrunber , Seems the type hierarchy API in JDT don't have a way of providing the search scope.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants