Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: set hardware address in API #60

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: set hardware address in API #60

wants to merge 1 commit into from

Conversation

y-young
Copy link

@y-young y-young commented Mar 8, 2023

No description provided.

@y-young y-young mentioned this pull request Mar 8, 2023
Closed
s1061123
s1061123 requested changes Mar 14, 2023
View reviewed changes
Copy link
Collaborator

@s1061123 s1061123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR, @y-young . Here is the comments

  • Please add comments in PR and commit, to explain what you changed.
  • Could you please add unit-tests to test the feature?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s1061123 s1061123 s1061123 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@y-young @s1061123