Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove mentions of Tox #2929

Merged
merged 2 commits into from
Sep 11, 2023
Merged

Remove mentions of Tox #2929

merged 2 commits into from
Sep 11, 2023

Conversation

akx
Copy link
Contributor

@akx akx commented Sep 4, 2023 •
edited
Loading

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
    • Unsurprisingly, no, since there is no Tox configuration.
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?
    • No, since the CHANGES file is currently very out of date.

Description of change

The PR checklist and other documentation refers to tox, but it was removed in #2849.

@akx akx mentioned this pull request Sep 4, 2023
Open
6 tasks
@chayim chayim requested a review from dvora-h September 10, 2023 11:14
@chayim chayim added the maintenance Maintenance (CI, Releases, etc) label Sep 10, 2023
@dvora-h dvora-h merged commit 1596ac6 into redis:master Sep 11, 2023
56 checks passed
@akx akx deleted the detox branch February 15, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvora-h dvora-h dvora-h approved these changes

Assignees
No one assigned
Labels
maintenance Maintenance (CI, Releases, etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akx @dvora-h @chayim