-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
frontend: Move to vite for build, runtime, tests #939
base: master
Are you sure you want to change the base?
Conversation
|
frontend/package.json
Outdated
"serve": "vite preview --port 3004", | ||
"test": "TZ=GMT jest --coverage --watchAll=false", | ||
"test:dev": "TZ=GMT jest --coverage --watchAll", | ||
"test-interpreter-code": "ts-node --project src/utils/interpreter/tsconfig.json src/utils/interpreter/findFunction.test.ts", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove
frontend/package.json
Outdated
"eslint": "^8.3.0", | ||
"eslint-config-react-app": "^7.0.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dev deps
frontend/package.json
Outdated
"antd": "^4.21", | ||
"array-move": "^4", | ||
"camelcase": "^6.2.1", | ||
"dotenv": "^10.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dev deps
frontend/package.json
Outdated
"jest-resolve": "^29.7.0", | ||
"jest-watch-typeahead": "^2.2.2", | ||
"node-fetch": "^3.3.0", | ||
"sass": "^1.58.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe remove?
frontend/package.json
Outdated
"typescript": "^4.9.5" | ||
}, | ||
"resolutions": { | ||
"//": "See https://github.com/facebook/create-react-app/issues/11773", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check if works after removing
@@ -1,5 +1,6 @@ | |||
import { Select as RPSelect } from '@redpanda-data/ui'; | |||
import { SelectProps as RPSelectProps, isSingleSelectOptions, isSingleValue } from '@redpanda-data/ui/dist/components/Inputs/Select/Select'; | |||
import { isSingleSelectOptions, isSingleValue } from '@redpanda-data/ui'; | |||
import { SelectProps as RPSelectProps } from '@redpanda-data/ui/dist/components/Inputs/Select/Select' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's export SelectProps via UI library, or any props of any component for that matter.
Thanks to @frankieshakes and @rikimaru0345 for the heads up.
@@ -2,12 +2,13 @@ | |||
"compilerOptions": { | |||
"experimentalDecorators": true, | |||
"useDefineForClassFields": true, | |||
"target": "es2019", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
react({ // Needed to keep using MobX with legacy decorator patterns enabled | ||
babel: { | ||
parserOpts: { | ||
plugins: ['decorators-legacy', 'classProperties'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 day we could get rid of decorators
3f48c9d
to
f43103e
Compare
WIP