Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup storage section #123

Merged
merged 1 commit into from
Jul 26, 2022
Merged

Conversation

vuldin
Copy link
Member

@vuldin vuldin commented Jul 21, 2022

  • remove storage.enabled
  • lower default PV size to 3Gi
  • add initContainer that properly changes ownership on mounted volume

A good side effect of changes in this PR is that minikube now works as expected with persistent volumes (see comments in #79).

closes #79

- closes redpanda-data#79
- remove storage.enabled
- lower default PV size to 3Gi
- add initContainer that properly changes ownership on mounted volume
@vuldin vuldin requested a review from r-vasquez July 21, 2022 17:22
Comment on lines +60 to +65
- name: set-datadir-ownership
image: busybox:latest
command: ["/bin/sh", "-c", "chown 101:101 -R /var/lib/redpanda/data"]
volumeMounts:
- name: datadir
mountPath: /var/lib/redpanda/data
Copy link
Contributor

@r-vasquez r-vasquez Jul 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[question] Is there a case where the user might want to change the default data_directory (/var/lib/redpanda/data)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think changing the default directory in a kubernetes (or helm) situation would be much less likely (than local install) since this is the container path, and this path is just a mount point for a persistent volume which could be multiple places (a completely different directory on the node, a remote storage device through some persistent storage cloud service, etc.). I can't think of a scenario right now where the customer would be using this path, unless they are connecting directly into the pod for some reason.

At the same time, this would be easy to provide as a modifiable parameter in values.yaml if we can think of a good reason to do so.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It's clear to me now :)

@vuldin vuldin merged commit c0b88a7 into redpanda-data:v2 Jul 26, 2022
@vuldin vuldin deleted the update-storage-config branch July 26, 2022 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants