Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connectors: add changes to allow this to be used as a subchart #625

Conversation

RafalKorepta
Copy link
Contributor

Similar how console deployment and configmap is rendered now connectors can be used as subchart

REF:
#328

@RafalKorepta RafalKorepta force-pushed the rk/allow-connectors-to-be-used-as-subchart branch 6 times, most recently from 9e3bf66 to 53acfec Compare August 1, 2023 10:12
Copy link
Contributor

@alejandroEsc alejandroEsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, this is just setting up for allowing you to subchart while overriding at the top level for the redpanda chart, correct?

charts/connectors/templates/deployment.yaml Outdated Show resolved Hide resolved
charts/connectors/templates/tests/01-mm2-values.yaml Outdated Show resolved Hide resolved
@RafalKorepta RafalKorepta force-pushed the rk/allow-connectors-to-be-used-as-subchart branch from 53acfec to 06b91c8 Compare August 1, 2023 16:34
Similar how console deployment and configmap is rendered now connectors can
be used as subchart

REF:
redpanda-data#328
@RafalKorepta RafalKorepta force-pushed the rk/allow-connectors-to-be-used-as-subchart branch from 06b91c8 to 93d1b3a Compare August 2, 2023 07:49
@RafalKorepta RafalKorepta merged commit c7d4f8e into redpanda-data:main Aug 2, 2023
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants