Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.babelrc should not be in npm repo #43

Closed
alinz opened this issue Dec 14, 2015 · 4 comments
Closed

.babelrc should not be in npm repo #43

alinz opened this issue Dec 14, 2015 · 4 comments

Comments

@alinz
Copy link

alinz commented Dec 14, 2015

I think babelrc is being published in npm which causes react-native app's to crash! It has been fixed in react-redux and redux. However this bug still exists in this module.
@alinz alinz mentioned this issue Dec 14, 2015
Closed
@jaunesarmiento
Copy link

+1

More discussion about this in facebook/react-native#4062

@jaunesarmiento jaunesarmiento mentioned this issue Dec 14, 2015
Closed
@gaearon
Copy link
Collaborator

gaearon commented Dec 20, 2015

(Note: it's not so much our bug as RN tooling issue. But I'm happy to push an update soon!)

@gaearon
Copy link
Collaborator

gaearon commented Dec 20, 2015

This should actually have already been fixed as of 1.0.2.

@gaearon gaearon closed this as completed Dec 20, 2015
@alinz
Copy link
Author

alinz commented Dec 21, 2015

@gaearon thanks for your update.

@RanzQ RanzQ mentioned this issue Feb 8, 2017
Closed
@jevakallio jevakallio mentioned this issue Mar 29, 2017
Closed
@sattaman sattaman mentioned this issue Apr 6, 2017
Merged
@erezrokah erezrokah mentioned this issue Oct 12, 2017
Merged
jluxenberg added a commit to jluxenberg/redux-multi that referenced this issue Oct 24, 2017
@jluxenberg
Add '.babelrc' to npmignore
afde395 
react-native projects use Babel 6, is incompatible with this
project's .babelrc. The babelrc file for an npm module should 
not be in the npm package at all, since transpilation should be 
done before publishing to npm, so we add .babelrc file to the 
npmignore file.

See similar issue in redux-thunk for more details
  reduxjs/redux-thunk#43
@jluxenberg jluxenberg mentioned this issue Oct 24, 2017
Open
@mpeyper mpeyper mentioned this issue Jan 25, 2018
Closed
@setok16 setok16 mentioned this issue Jun 11, 2018
Open
anru added a commit to anru/utils.js that referenced this issue Jun 29, 2018
@anru
get rid of pushing .babelrc in npm package
4273c47 
for details see reduxjs/redux-thunk#43
@anru anru mentioned this issue Jun 29, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gaearon @alinz @jaunesarmiento