Use original instead of immer draft for perf

reduxjs · Apr 16, 2023 · 0c8d3e3 · 0c8d3e3
1 parent 23a78ca
commit 0c8d3e3
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/packages/toolkit/src/query/core/buildSlice.ts b/packages/toolkit/src/query/core/buildSlice.ts
@@ -31,8 +31,8 @@ import type {
   EndpointDefinitions,
   QueryDefinition,
 } from '../endpointDefinitions'
-import type { Patch } from 'immer'
-import { applyPatches } from 'immer'
+import { isDraft, Patch } from 'immer'
+import { applyPatches, original } from 'immer'
 import { onFocus, onFocusLost, onOffline, onOnline } from './setupListeners'
 import {
   isDocumentVisible,
@@ -208,7 +208,12 @@ export function buildSlice({
                 // Assign or safely update the cache data.
                 substate.data =
                   definitions[meta.arg.endpointName].structuralSharing ?? true
-                    ? copyWithStructuralSharing(substate.data, payload)
+                    ? copyWithStructuralSharing(
+                        isDraft(substate.data)
+                          ? original(substate.data)
+                          : substate.data,
+                        payload
+                      )
                     : payload
               }