docs(how-to): replace crypto-js with node's crypto module for random number generation in passwordless auth #11568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the last remaining place in the guide where 3rd-party crypto-js package is used. Replaced with crypto-js with node's crypto module to simplify the code and get rid of external dependency. One thing I'm not certain about is how proposed changes compare with the existing solution from the security point of view. `crypto.randomInt()` should be secure, but after generating a number I padStart the value with "0" which may reduce randomness I guess. However the same is done for crypto-js generated values as well, so I would assume it shouldn't be less secure.
Tobbe
added
release:docs
Josh-Walker-GM
pushed a commit
that referenced
this pull request
Sep 16, 2024
…number generation in passwordless auth (#11568)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the last remaining place in the guide where 3rd-party crypto-js package is used. Replaced crypto-js with node's crypto module to simplify the code and get rid of external dependency.
One thing I'm not certain about is how proposed changes compare with the existing solution from the security point of view.
crypto.randomInt()should be secure, but after generating a number I padStart the value with "0" which may reduce randomness I guess. However the same is done for crypto-js generated values as well, so I would assume it shouldn't be less secure.