-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(package/appwrite): update appwrite
sdk to 15.0.0
#6138
feat(package/appwrite): update appwrite
sdk to 15.0.0
#6138
Conversation
🦋 Changeset detectedLatest commit: efff46a The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
appwrite
sdk to 14.0.1
#6090appwrite
sdk to 14.0.1
#
appwrite
sdk to 14.0.1
#appwrite
sdk to 14.0.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @soranoo thanks for the PR, added some comments for changes.
Done, plz take a look. |
Should I update the root deps? The CI keep failing because of the incorrect ver of appwrite sdk. |
@soranoo you need to do pnpm install to update pnpm-lock.yaml. Also we'll provide new appwrite credentials, so we can record tests again. These tests doesn't ensure that it works correctly, just make assertions on already hardcoded mocks. |
appwrite
sdk to 14.0.1
appwrite
sdk to 15.0.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @soranoo, is there any specific reason for you to stay in v14 instead of 15?
There was some issues with our tests, I've updated them accordingly with fresh data. Also due to the changes in the SDK, updated one line in examples.
Also bumped Appwrite dependency to 15 🤔 Any reason behind the downgrade to 14?
Thank you for your contribution! 🙏
The package works with Appwrite SDK 15.0.0 but the tests don't. The whole package is able to update to 13.0.1 without any issues and with some test modifications to work with 14.0.1 Here's the problem I am facing But you just got everything on the right track. |
…pwrite`-SDK-to-`14.0.1`
PR Checklist
Please check if your PR fulfills the following requirements:
Bugs / Features
What is the current behavior?
What is the new behavior?
fixes (issue)
Notes for reviewers