Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(package/appwrite): update appwrite sdk to 15.0.0 #6138

Conversation

soranoo
Copy link
Contributor

@soranoo soranoo commented Jul 13, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

Bugs / Features

What is the current behavior?

What is the new behavior?

fixes (issue)

Notes for reviewers

@soranoo soranoo requested a review from a team as a code owner July 13, 2024 18:11
Copy link

changeset-bot bot commented Jul 13, 2024

🦋 Changeset detected

Latest commit: efff46a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@refinedev/appwrite Major
@refinedev/live-previews Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@soranoo soranoo changed the title feat(package/appwrite): update appwrite sdk to 14.0.1 #6090 feat(package/appwrite): update appwrite sdk to 14.0.1 # Jul 13, 2024
@soranoo soranoo changed the title feat(package/appwrite): update appwrite sdk to 14.0.1 # feat(package/appwrite): update appwrite sdk to 14.0.1 Jul 13, 2024
Copy link
Member

@BatuhanW BatuhanW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @soranoo thanks for the PR, added some comments for changes.

packages/appwrite/CHANGELOG.md Outdated Show resolved Hide resolved
packages/appwrite/package.json Outdated Show resolved Hide resolved
.changeset/silver-crabs-relax.md Show resolved Hide resolved
@BatuhanW BatuhanW added this to the August Release milestone Jul 16, 2024
@soranoo
Copy link
Contributor Author

soranoo commented Jul 16, 2024

Done, plz take a look.

@soranoo soranoo requested a review from BatuhanW July 16, 2024 10:38
@soranoo
Copy link
Contributor Author

soranoo commented Jul 17, 2024

Should I update the root deps? The CI keep failing because of the incorrect ver of appwrite sdk.

@BatuhanW
Copy link
Member

@soranoo you need to do pnpm install to update pnpm-lock.yaml. Also we'll provide new appwrite credentials, so we can record tests again. These tests doesn't ensure that it works correctly, just make assertions on already hardcoded mocks.

@BatuhanW BatuhanW changed the base branch from master to releases/august July 17, 2024 11:00
@aliemir aliemir linked an issue Jul 19, 2024 that may be closed by this pull request
@aliemir aliemir changed the title feat(package/appwrite): update appwrite sdk to 14.0.1 feat(package/appwrite): update appwrite sdk to 15.0.0 Jul 23, 2024
Copy link
Member

@aliemir aliemir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @soranoo, is there any specific reason for you to stay in v14 instead of 15?

There was some issues with our tests, I've updated them accordingly with fresh data. Also due to the changes in the SDK, updated one line in examples.

Also bumped Appwrite dependency to 15 🤔 Any reason behind the downgrade to 14?

Thank you for your contribution! 🙏

@soranoo
Copy link
Contributor Author

soranoo commented Jul 23, 2024

The package works with Appwrite SDK 15.0.0 but the tests don't. The whole package is able to update to 13.0.1 without any issues and with some test modifications to work with 14.0.1

Here's the problem I am facing
#6090 (comment)

But you just got everything on the right track.
Thank you ❤️

@BatuhanW BatuhanW assigned alicanerdurmaz and unassigned aliemir Jul 26, 2024
@aliemir aliemir merged commit d4809d6 into refinedev:releases/august Jul 30, 2024
12 checks passed
@aliemir aliemir mentioned this pull request Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Update @refinedev/appwrite's Appwrite SDK version
4 participants