Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ecocredit): remove info suffix from state proto messages #1040

Merged
merged 3 commits into from
Apr 21, 2022

Conversation

aleem1314
Copy link
Contributor

@aleem1314 aleem1314 commented Apr 20, 2022

Description

Closes: #1029


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented Apr 20, 2022

Codecov Report

Merging #1040 (b41a71c) into master (9aa86c4) will decrease coverage by 10.90%.
The diff coverage is 86.45%.

❗ Current head b41a71c differs from pull request most recent head d482da0. Consider uploading reports for the commit d482da0 to get more accurate results

@@             Coverage Diff             @@
##           master    #1040       +/-   ##
===========================================
- Coverage   59.83%   48.92%   -10.91%     
===========================================
  Files         226      225        -1     
  Lines       22765    23442      +677     
===========================================
- Hits        13622    11470     -2152     
- Misses       7823    10718     +2895     
+ Partials     1320     1254       -66     
Flag Coverage Δ
experimental-codecov 48.81% <86.45%> (-10.92%) ⬇️
stable-codecov 41.70% <86.45%> (-11.58%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@aleem1314 aleem1314 marked this pull request as ready for review April 20, 2022 16:00
Copy link
Member

@ryanchristo ryanchristo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

proto/regen/ecocredit/v1/query.proto Outdated Show resolved Hide resolved
@ryanchristo ryanchristo merged commit 5819dcb into master Apr 21, 2022
@ryanchristo ryanchristo deleted the aleem/1029-remove-info-suffix branch April 21, 2022 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Info suffix from ecocredit state proto messages
4 participants