Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(x/data): add events for data resolver #1051

Merged
merged 4 commits into from
Apr 26, 2022

Conversation

ryanchristo
Copy link
Member

@ryanchristo ryanchristo commented Apr 25, 2022

Description

Closes: #1050

Add EventDefineResolver and EventRegisterResolver and implement in msg server.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented Apr 25, 2022

Codecov Report

Merging #1051 (d707981) into master (002a876) will increase coverage by 0.05%.
The diff coverage is 71.42%.

❗ Current head d707981 differs from pull request most recent head b9ca470. Consider uploading reports for the commit b9ca470 to get more accurate results

@@            Coverage Diff             @@
##           master    #1051      +/-   ##
==========================================
+ Coverage   59.61%   59.66%   +0.05%     
==========================================
  Files         230      230              
  Lines       23289    23301      +12     
==========================================
+ Hits        13884    13903      +19     
+ Misses       8063     8059       -4     
+ Partials     1342     1339       -3     
Flag Coverage Δ
experimental-codecov 59.52% <71.42%> (+<0.01%) ⬆️
stable-codecov 53.32% <71.42%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ryanchristo ryanchristo marked this pull request as ready for review April 25, 2022 22:04
Copy link
Contributor

@aleem1314 aleem1314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@technicallyty technicallyty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ryanchristo ryanchristo enabled auto-merge (squash) April 26, 2022 17:56
@ryanchristo ryanchristo merged commit 4cccb72 into master Apr 26, 2022
@ryanchristo ryanchristo deleted the ryan/1050-resolver-events branch April 26, 2022 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add events for defining a resolver and registering data
3 participants