Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ecocredit): add credit types state migration #1061

Merged
merged 11 commits into from
May 4, 2022

Conversation

aleem1314
Copy link
Contributor

@aleem1314 aleem1314 commented Apr 27, 2022

Description

Ref: #1049


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented Apr 27, 2022

Codecov Report

Merging #1061 (f419fe5) into master (2b08585) will decrease coverage by 0.31%.
The diff coverage is 16.30%.

@@            Coverage Diff             @@
##           master    #1061      +/-   ##
==========================================
- Coverage   68.70%   68.39%   -0.32%     
==========================================
  Files         216      216              
  Lines       21355    21418      +63     
==========================================
- Hits        14672    14648      -24     
- Misses       5337     5416      +79     
- Partials     1346     1354       +8     
Flag Coverage Δ
experimental-codecov 68.39% <16.30%> (-0.21%) ⬇️
stable-codecov ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@aleem1314 aleem1314 marked this pull request as ready for review April 29, 2022 12:20
Copy link
Member

@ryanchristo ryanchristo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. A small nit and an undefined variable.

x/ecocredit/migrations/v3/core.go Outdated Show resolved Hide resolved
x/ecocredit/migrations/v3/core.go Show resolved Hide resolved
aleem1314 and others added 3 commits May 2, 2022 14:23
Co-authored-by: Ryan Christoffersen <12519942+ryanchristo@users.noreply.github.com>
Copy link
Contributor

@technicallyty technicallyty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Member

@ryanchristo ryanchristo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. A couple nits and a question.

x/ecocredit/migrations/v3/params.go Outdated Show resolved Hide resolved
x/ecocredit/migrations/v3/params.go Outdated Show resolved Hide resolved
x/ecocredit/migrations/v3/params.go Outdated Show resolved Hide resolved
x/ecocredit/migrations/v3/params.go Outdated Show resolved Hide resolved
@aleem1314 aleem1314 requested a review from ryanchristo May 4, 2022 09:07
Copy link
Member

@ryanchristo ryanchristo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@ryanchristo ryanchristo enabled auto-merge (squash) May 4, 2022 16:48
@ryanchristo ryanchristo merged commit 646a04d into master May 4, 2022
@ryanchristo ryanchristo deleted the aleem/1049-params-migration branch May 4, 2022 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants