Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove deprecated orm package #1076

Merged
merged 3 commits into from
May 4, 2022
Merged

Conversation

ryanchristo
Copy link
Member

Description

The orm package is no longer maintained and no changes that affect the group module have been made since the release of v1.0.0-beta1. This pull request removes the orm package and updates the group module to use v1.0.0-beta1 (the ecocredit module is already using v1.0.0-beta1, which is needed for state migrations).


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented May 2, 2022

Codecov Report

Merging #1076 (01b0f8a) into master (9f915eb) will decrease coverage by 0.51%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1076      +/-   ##
==========================================
- Coverage   68.45%   67.94%   -0.52%     
==========================================
  Files         217      205      -12     
  Lines       21490    20812     -678     
==========================================
- Hits        14712    14140     -572     
+ Misses       5431     5359      -72     
+ Partials     1347     1313      -34     
Flag Coverage Δ
experimental-codecov 67.94% <ø> (-0.43%) ⬇️
stable-codecov ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@technicallyty technicallyty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks gone to me! 😉

@ryanchristo ryanchristo enabled auto-merge (squash) May 4, 2022 19:12
@ryanchristo ryanchristo merged commit cfd8d1d into master May 4, 2022
@ryanchristo ryanchristo deleted the ryan/remove-orm-package branch May 4, 2022 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants