refactor(x/ecocredit): consistent amount and key field names #1123
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request cleans up the following core and marketplace field names:
SellOrder.AskPrice
renamed toSellOrder.AskAmount
("price" is the denom and amount combined)SellOrderInfo.AskPrice
renamed toSellOrderInfo.AskAmount
("price" is the denom and amount combined)SellOrder.BatchId
renamed toSellOrder.BatchKey
(followup from renaming internal id to key in core)Market.CreditType
renamed toMarket.CreditTypeAbbrev
(followup from renaming credit type in core)BatchBalance.Tradable
renamed toBatchBalance.TradableAmount
(consistent with supply and send credits)BatchBalance.Retired
renamed toBatchBalance.RetiredAmount
(consistent with supply and send credits)BatchBalance.Escrowed
renamed toBatchBalance.EscrowedAmount
(consistent with tradable and retired)BatchBalanceInfo.Tradable
renamed toBatchBalanceInfo.TradableAmount
(consistent with supply and send credits)BatchBalanceInfo.Retired
renamed toBatchBalanceInfo.RetiredAmount
(consistent with supply and send credits)BatchBalanceInfo.Escrowed
renamed toBatchBalanceInfo.EscrowedAmount
(consistent with tradable and retired)Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change