Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(x/ecocredit): consistent amount and key field names #1123

Merged
merged 3 commits into from
May 27, 2022

Conversation

ryanchristo
Copy link
Member

Description

This pull request cleans up the following core and marketplace field names:

  • SellOrder.AskPrice renamed to SellOrder.AskAmount ("price" is the denom and amount combined)
  • SellOrderInfo.AskPrice renamed to SellOrderInfo.AskAmount ("price" is the denom and amount combined)
  • SellOrder.BatchId renamed to SellOrder.BatchKey (followup from renaming internal id to key in core)
  • Market.CreditType renamed to Market.CreditTypeAbbrev (followup from renaming credit type in core)
  • BatchBalance.Tradable renamed to BatchBalance.TradableAmount (consistent with supply and send credits)
  • BatchBalance.Retired renamed to BatchBalance.RetiredAmount (consistent with supply and send credits)
  • BatchBalance.Escrowed renamed to BatchBalance.EscrowedAmount (consistent with tradable and retired)
  • BatchBalanceInfo.Tradable renamed to BatchBalanceInfo.TradableAmount (consistent with supply and send credits)
  • BatchBalanceInfo.Retired renamed to BatchBalanceInfo.RetiredAmount (consistent with supply and send credits)
  • BatchBalanceInfo.Escrowed renamed to BatchBalanceInfo.EscrowedAmount (consistent with tradable and retired)

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@ryanchristo ryanchristo marked this pull request as ready for review May 23, 2022 18:45
@codecov
Copy link

codecov bot commented May 23, 2022

Codecov Report

Merging #1123 (24f79a2) into master (852fb8d) will decrease coverage by 0.04%.
The diff coverage is 89.75%.

@@            Coverage Diff             @@
##           master    #1123      +/-   ##
==========================================
- Coverage   69.86%   69.82%   -0.05%     
==========================================
  Files         218      218              
  Lines       22243    22243              
==========================================
- Hits        15541    15531      -10     
- Misses       5365     5372       +7     
- Partials     1337     1340       +3     
Flag Coverage Δ
experimental-codecov 69.66% <89.75%> (-0.10%) ⬇️
stable-codecov 64.17% <89.75%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@clevinson clevinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack!

@clevinson clevinson merged commit eb54e96 into master May 27, 2022
@clevinson clevinson deleted the ryan/consistent-amount-key branch May 27, 2022 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants