-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(x/ecocredit): consistent origin tx and separate mint events #1125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanchristo
commented
May 23, 2022
Codecov Report
@@ Coverage Diff @@
## master #1125 +/- ##
=========================================
Coverage ? 64.02%
=========================================
Files ? 215
Lines ? 20332
Branches ? 0
=========================================
Hits ? 13018
Misses ? 6045
Partials ? 1269
Flags with carried forward coverage won't be shown. Click here to find out more. |
aleem1314
approved these changes
May 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
clevinson
reviewed
May 26, 2022
clevinson
approved these changes
May 26, 2022
Co-authored-by: Cory <cjlevinson@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request make the following changes:
BatchOrigTx
toBatchOriginTx
OriginTx
andBatchOriginTx
field nametyp
tosource
(consistent with outboundtarget
)BatchOriginTx
field nametx_id
toid
and updates primary key toid,source
origin_tx
toEventCreateBatch
(a batch may be created from a bridge event)EventMint
for when credits are minted either as a result of creating a new batch (issuing credits) or dynamically minting credits to an existing batch (bridging credits)Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change