Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(basket)!: store basket denom units in ascending order #1202

Merged
merged 4 commits into from
Jun 21, 2022

Conversation

aleem1314
Copy link
Contributor

Description

Ref: #1190(comment)


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

denomUnits := make([]*banktypes.DenomUnit, 0)

// Set denomination units in ascending order and
// the first denomination unit must be the base
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aleem1314 aleem1314 marked this pull request as ready for review June 21, 2022 14:19
@aleem1314 aleem1314 requested a review from anilcse June 21, 2022 15:21
@codecov
Copy link

codecov bot commented Jun 21, 2022

Codecov Report

Merging #1202 (9c29414) into master (22622fb) will decrease coverage by 0.14%.
The diff coverage is 100.00%.

❗ Current head 9c29414 differs from pull request most recent head e81c3ce. Consider uploading reports for the commit e81c3ce to get more accurate results

@@            Coverage Diff             @@
##           master    #1202      +/-   ##
==========================================
- Coverage   70.26%   70.12%   -0.15%     
==========================================
  Files         234      235       +1     
  Lines       23595    23781     +186     
==========================================
+ Hits        16580    16677      +97     
- Misses       5605     5669      +64     
- Partials     1410     1435      +25     
Flag Coverage Δ
experimental-codecov 70.47% <100.00%> (+0.16%) ⬆️
stable-codecov 64.88% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@technicallyty technicallyty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@ryanchristo ryanchristo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. As discussed on our call, we will need a manual migration for redwood and we don't have baskets on mainnet so we should be in the clear there.

@ryanchristo
Copy link
Member

Opened #1204 as a followup.

@ryanchristo ryanchristo merged commit 5de1015 into master Jun 21, 2022
@ryanchristo ryanchristo deleted the aleem/fix-bskt-denom-units branch June 21, 2022 18:32
@ryanchristo ryanchristo mentioned this pull request Jun 27, 2022
31 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants