feat(x/data): unique constraints on resolver url and manager #1219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Codecov Report
@@ Coverage Diff @@
## master #1219 +/- ##
==========================================
+ Coverage 70.96% 71.02% +0.06%
==========================================
Files 241 241
Lines 24342 24345 +3
==========================================
+ Hits 17274 17291 +17
+ Misses 5654 5638 -16
- Partials 1414 1416 +2
Flags with carried forward coverage won't be shown. Click here to find out more. |
proto/regen/data/v1/state.proto
Outdated
| @@ -62,6 +62,7 @@ message Resolver { | |||
| primary_key : {fields : "id", auto_increment : true} | |||
| index : {id : 1, fields : "url"} | |||
| index : {id : 2, fields : "manager"} | |||
There was a problem hiding this comment.
was wondering if the new index below allows us to remove any of these other ones, and i couldn't seem to find any with the manager index being used. is it still needed?
There was a problem hiding this comment.
Looks like it wasn't being used. Removed in 73aeb6e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #1212
This pull request adds unique constraints on resolver url and manager combination.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change