Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: use mock wasmd for stable build #1255

Merged
merged 13 commits into from
Jul 13, 2022
Merged

build: use mock wasmd for stable build #1255

merged 13 commits into from
Jul 13, 2022

Conversation

ryanchristo
Copy link
Member

@ryanchristo ryanchristo commented Jul 12, 2022

Description

Closes: #1164

Adds a mock wasmd module used in stable build and experimental integration tests and enables arm and windows builds which are no longer restricted by wasmd dependencies.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@ryanchristo ryanchristo marked this pull request as ready for review July 12, 2022 23:58
@@ -29,4 +29,4 @@ jobs:
version: latest
args: release --rm-dist
env:
GITHUB_TOKEN: ${{ secrets.github_token }}
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Secret names are case sensitive so I'm hoping this was the issue with homebrew publish.

@@ -0,0 +1,72 @@
package keeper

// https://github.com/CosmWasm/wasmd/blob/v0.22.0/x/wasm/keeper/ante.go
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copied the code from here. This was needed for integration tests to work with experimental.

Copy link
Contributor

@technicallyty technicallyty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK - make build & make test work on m1 🥳

@codecov
Copy link

codecov bot commented Jul 13, 2022

Codecov Report

Merging #1255 (0dd0fa0) into master (e5b2f1f) will increase coverage by 0.03%.
The diff coverage is 14.28%.

@@            Coverage Diff             @@
##           master    #1255      +/-   ##
==========================================
+ Coverage   80.07%   80.11%   +0.03%     
==========================================
  Files         234      234              
  Lines       21548    21556       +8     
==========================================
+ Hits        17255    17269      +14     
+ Misses       3006     2996      -10     
- Partials     1287     1291       +4     
Flag Coverage Δ
experimental-codecov 80.14% <ø> (ø)
stable-codecov 75.88% <14.28%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
app/experimental_ante.go 61.29% <ø> (ø)
x/ecocredit/migrations/v3/params.go 9.85% <ø> (ø)
x/ecocredit/migrations/v3/state.go 61.79% <ø> (ø)
app/stable_appconfig.go 59.45% <14.28%> (-2.68%) ⬇️
types/ormstore/store.go 39.73% <0.00%> (+3.90%) ⬆️

@ryanchristo ryanchristo merged commit 8597f8c into master Jul 13, 2022
@ryanchristo ryanchristo deleted the ryan/mock-cosmwasm branch July 13, 2022 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate and resolve goreleaser build issues
3 participants