Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(x/ecocredit)!: migrate add-allow-denom proposal to msg based proposal #1342

Merged
merged 17 commits into from
Aug 12, 2022

Conversation

aleem1314
Copy link
Contributor

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented Aug 10, 2022

Codecov Report

❗ No coverage uploaded for pull request base (master@073b1e4). Click here to learn what that means.
The diff coverage is 82.75%.

❗ Current head 8cb3214 differs from pull request most recent head 7b76260. Consider uploading reports for the commit 7b76260 to get more accurate results

@@            Coverage Diff            @@
##             master    #1342   +/-   ##
=========================================
  Coverage          ?   77.40%           
=========================================
  Files             ?      211           
  Lines             ?    15395           
  Branches          ?        0           
=========================================
  Hits              ?    11916           
  Misses            ?     2576           
  Partials          ?      903           
Impacted Files Coverage Δ
app/app.go 73.55% <ø> (ø)
x/ecocredit/marketplace/msg_add_allowed_denom.go 60.00% <60.00%> (ø)
...credit/server/marketplace/msg_add_allowed_denom.go 93.33% <93.33%> (ø)
x/ecocredit/marketplace/codec.go 100.00% <100.00%> (ø)
x/ecocredit/server/marketplace/keeper.go 100.00% <100.00%> (ø)
x/ecocredit/server/server.go 73.91% <100.00%> (ø)

@aleem1314 aleem1314 marked this pull request as ready for review August 11, 2022 12:35
@aleem1314 aleem1314 requested a review from a team August 11, 2022 12:35
@@ -5,9 +5,6 @@ package regen.ecocredit.marketplace.v1;
import "gogoproto/gogo.proto";
import "regen/ecocredit/marketplace/v1/state.proto";

option go_package =
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are not using AllowDenomProposal message. Removing this line is breaking buf-lint check.

Copy link
Contributor

@technicallyty technicallyty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, 2 tiny nits

CHANGELOG.md Outdated Show resolved Hide resolved
aleem1314 and others added 3 commits August 12, 2022 12:42
Co-authored-by: Tyler <48813565+technicallyty@users.noreply.github.com>
…feature

Co-authored-by: Tyler <48813565+technicallyty@users.noreply.github.com>
Copy link
Member

@ryanchristo ryanchristo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ryanchristo
Copy link
Member

ryanchristo commented Aug 12, 2022

Each file within a proto package must have the same go package option. Even though we don't need the generated code for the proposal in marketplace types, we need to keep the go package option.

Files in package "regen.ecocredit.marketplace.v1" have both values "github.com/regen-network/regen-ledger/x/ecocredit/marketplace" and no value for option "go_package" and all values must be equal.

@ryanchristo ryanchristo changed the title feat(marketplace)!: migrate add-allow-denom proposal to msg based proposal feat(x/ecocredit)!: migrate add-allow-denom proposal to msg based proposal Aug 12, 2022
@ryanchristo ryanchristo merged commit d68aa03 into master Aug 12, 2022
@ryanchristo ryanchristo deleted the aleem/msg-add-allowed-denom branch August 12, 2022 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants