style: update golangci config and fix lint errors #1384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanchristo
commented
Aug 20, 2022
| @@ -1,4 +1,4 @@ | |||
| package grpc_gateway | |||
| package grpcgateway | |||
ryanchristo
commented
Aug 20, 2022
Comment on lines
+10
to
+11
| // ToAPI converts to pulsar based data structure | ||
| func (d *DateCriteria) ToAPI() *api.DateCriteria { |
ryanchristo
commented
Aug 20, 2022
Comment on lines
+476
to
+477
| // QueryProjectsByReferenceIDCmd returns command that retrieves list of projects by reference id with pagination. | ||
| func QueryProjectsByReferenceIDCmd() *cobra.Command { |
ryanchristo
commented
Aug 20, 2022
| @@ -23,7 +23,7 @@ import ( | |||
| const ( | |||
| FlagAddIssuers string = "add-issuers" | |||
| FlagRemoveIssuers string = "remove-issuers" | |||
| FlagReferenceId string = "reference-id" | |||
| FlagReferenceID string = "reference-id" | |||
ryanchristo
commented
Aug 20, 2022
| @@ -8,7 +8,7 @@ import ( | |||
| "github.com/regen-network/regen-ledger/x/ecocredit" | |||
| ) | |||
|
|
|||
| const MaxReferenceIdLength = 32 | |||
| const MaxReferenceIDLength = 32 | |||
ryanchristo
commented
Aug 20, 2022
Comment on lines
+36
to
+37
| RegexClassID = `[A-Z]{1,3}[0-9]{2,}` | ||
| RegexProjectID = fmt.Sprintf(`%s-[A-Z0-9]{2,}`, RegexClassID) |
ryanchristo
commented
Aug 20, 2022
| @@ -58,24 +56,24 @@ var ( | |||
| // least three digits | |||
| // | |||
| // e.g. C01 | |||
| func FormatClassId(creditTypeAbbreviation string, classSeqNo uint64) string { | |||
| func FormatClassID(creditTypeAbbreviation string, classSeqNo uint64) string { | |||
ryanchristo
commented
Aug 20, 2022
| // <project-sequence> is the sequence number of the project, padded to at least | ||
| // three digits | ||
| // | ||
| // e.g. C01-001 | ||
| func FormatProjectId(classId string, projectSeqNo uint64) string { | ||
| return fmt.Sprintf("%s-%03d", classId, projectSeqNo) | ||
| func FormatProjectID(classID string, projectSeqNo uint64) string { |
ryanchristo
commented
Aug 20, 2022
| if classId == "" { | ||
| // ValidateClassID validates a class ID conforms to the format described in | ||
| // FormatClassID. The return is nil if the ID is valid. | ||
| func ValidateClassID(classID string) error { |
ryanchristo
commented
Aug 20, 2022
| if projectId == "" { | ||
| // ValidateProjectID validates a project ID conforms to the format described | ||
| // in FormatProjectID. The return is nil if the ID is valid. | ||
| func ValidateProjectID(projectID string) error { |
ryanchristo
commented
Aug 20, 2022
| // GetClassIdFromProjectId returns the credit class ID in a project ID. | ||
| func GetClassIdFromProjectId(projectId string) string { | ||
| // GetClassIDFromProjectID returns the credit class ID in a project ID. | ||
| func GetClassIDFromProjectID(projectID string) string { |
ryanchristo
commented
Aug 20, 2022
| // GetClassIdFromBatchDenom returns the credit class ID in a batch denom. | ||
| func GetClassIdFromBatchDenom(denom string) string { | ||
| // GetClassIDFromBatchDenom returns the credit class ID in a batch denom. | ||
| func GetClassIDFromBatchDenom(denom string) string { |
ryanchristo
commented
Aug 20, 2022
| // GetProjectIdFromBatchDenom returns the credit project ID in a batch denom. | ||
| func GetProjectIdFromBatchDenom(denom string) string { | ||
| // GetProjectIDFromBatchDenom returns the credit project ID in a batch denom. | ||
| func GetProjectIDFromBatchDenom(denom string) string { |
ryanchristo
commented
Aug 20, 2022
| // GetCreditTypeAbbrevFromClassId returns the credit type abbreviation in a credit class id | ||
| func GetCreditTypeAbbrevFromClassId(classId string) string { | ||
| // GetCreditTypeAbbrevFromClassID returns the credit type abbreviation in a credit class id | ||
| func GetCreditTypeAbbrevFromClassID(classID string) string { |
ryanchristo
commented
Aug 20, 2022
Comment on lines
+36
to
+37
| // SupplyInvariant cross check the balance of baskets and bank | ||
| func SupplyInvariant(ctx sdk.Context, store api.BasketTable, bank bankSupplyStore, basketBalances map[uint64]math.Dec) (string, bool) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request updates the lint configuration and fixes lint errors and warnings. This pull request also updates workflows to ensure each module is checked if changes are made within the given module and skips checks if no changes are made.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change