Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(x/ecocredit): query all credit holders #1416

Merged
merged 8 commits into from
Aug 30, 2022

Conversation

technicallyty
Copy link
Contributor

@technicallyty technicallyty commented Aug 25, 2022

Description

  • adds a query that gets all credit holders w/ their balances

this is a simplified query as doing sorting/consolidating of balances based on address would make behavior with pagination be a bit too wonky, and in some cases could slow down a node.

Closes: #1110


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@ryanchristo ryanchristo changed the title feat(x/ecocredit) query all credit holders feat(x/ecocredit): query all credit holders Aug 26, 2022
@codecov
Copy link

codecov bot commented Aug 29, 2022

Codecov Report

Merging #1416 (2561076) into main (fbde113) will decrease coverage by 0.09%.
The diff coverage is 61.17%.

@@            Coverage Diff             @@
##             main    #1416      +/-   ##
==========================================
- Coverage   78.67%   78.58%   -0.10%     
==========================================
  Files         235      236       +1     
  Lines       18053    18127      +74     
==========================================
+ Hits        14204    14245      +41     
- Misses       3052     3074      +22     
- Partials      797      808      +11     
Impacted Files Coverage Δ
x/ecocredit/migrations/v3/state.go 47.50% <44.44%> (-27.50%) ⬇️
x/ecocredit/server/core/query_all_balances.go 50.00% <50.00%> (ø)
x/ecocredit/client/testsuite/grpc.go 100.00% <100.00%> (ø)

@technicallyty technicallyty marked this pull request as ready for review August 29, 2022 23:01
@technicallyty technicallyty requested a review from a team August 29, 2022 23:01
Copy link
Member

@ryanchristo ryanchristo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ryanchristo ryanchristo merged commit 9c6ecef into main Aug 30, 2022
@ryanchristo ryanchristo deleted the ty/1110-all_credit_holders branch August 30, 2022 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to query all credit holders with pagination
2 participants