Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): dec from string must be finite #1590

Merged
merged 2 commits into from
Nov 7, 2022
Merged

Conversation

aleem1314
Copy link
Contributor

Description

Closes: #1493


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@aleem1314 aleem1314 marked this pull request as ready for review November 3, 2022 15:08
@aleem1314 aleem1314 requested a review from a team November 3, 2022 15:08
@codecov
Copy link

codecov bot commented Nov 3, 2022

Codecov Report

Merging #1590 (5f53e32) into main (e06a36b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1590   +/-   ##
=======================================
  Coverage   77.58%   77.59%           
=======================================
  Files         263      263           
  Lines       19265    19269    +4     
=======================================
+ Hits        14947    14951    +4     
  Misses       3453     3453           
  Partials      865      865           
Impacted Files Coverage Δ
types/math/dec.go 96.02% <100.00%> (+0.10%) ⬆️

Copy link
Member

@ryanchristo ryanchristo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@technicallyty technicallyty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ryanchristo ryanchristo merged commit 7c9e329 into main Nov 7, 2022
@ryanchristo ryanchristo deleted the aleem/1493-inf-dec branch November 7, 2022 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NewPositiveDecimalFromStrings expects error when value is iNf
3 participants