Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(x/ecocredit): add batch denom to event bridge #1837

Merged
merged 2 commits into from
Mar 21, 2023

Conversation

ryanchristo
Copy link
Member

Description

This pull request adds batch_denom to EventBridge to make verification easier on the bridge service.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@ryanchristo ryanchristo added the backport/v5.1.x backport to release/v5.1.x branch label Mar 20, 2023
@codecov
Copy link

codecov bot commented Mar 20, 2023

Codecov Report

Merging #1837 (a8b04c6) into main (7673be6) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head a8b04c6 differs from pull request most recent head 0b86057. Consider uploading reports for the commit 0b86057 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1837   +/-   ##
=======================================
  Coverage   73.01%   73.01%           
=======================================
  Files         228      228           
  Lines       13581    13582    +1     
=======================================
+ Hits         9916     9917    +1     
  Misses       2934     2934           
  Partials      731      731           
Impacted Files Coverage Δ
x/ecocredit/base/keeper/msg_bridge.go 69.04% <100.00%> (+0.75%) ⬆️

@ryanchristo ryanchristo marked this pull request as ready for review March 20, 2023 22:50
@ryanchristo ryanchristo requested a review from a team March 20, 2023 22:50
@ryanchristo ryanchristo merged commit 61091a3 into main Mar 21, 2023
@ryanchristo ryanchristo deleted the ryan/event-bridge-batch-denom branch March 21, 2023 16:18
mergify bot pushed a commit that referenced this pull request Mar 21, 2023
ryanchristo added a commit that referenced this pull request Mar 21, 2023
…1839)

Co-authored-by: Ryan Christoffersen <12519942+ryanchristo@users.noreply.github.com>
@ryanchristo ryanchristo mentioned this pull request Mar 23, 2023
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v5.1.x backport to release/v5.1.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants