Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: register ibc client update proposal handlers #1857

Merged
merged 1 commit into from
Mar 24, 2023

Conversation

aleem1314
Copy link
Contributor

Description

Upgrade IBC client proposal is failing with error

Error: no concrete type registered for type URL /ibc.core.client.v1.ClientUpdateProposal against interface *types.Msg

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@aleem1314 aleem1314 requested a review from a team March 24, 2023 09:46
@ryanchristo ryanchristo added the backport/v5.1.x backport to release/v5.1.x branch label Mar 24, 2023
Copy link
Member

@ryanchristo ryanchristo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK. Verified configuration here. Thanks @aleem1314!

@ryanchristo ryanchristo merged commit 360f8d9 into main Mar 24, 2023
@ryanchristo ryanchristo deleted the aleem/register-ibc-gov-handlers branch March 24, 2023 17:35
@ryanchristo ryanchristo mentioned this pull request Mar 24, 2023
27 tasks
mergify bot pushed a commit that referenced this pull request Mar 24, 2023
ryanchristo pushed a commit that referenced this pull request Mar 24, 2023
…1858)

Co-authored-by: MD Aleem <72057206+aleem1314@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v5.1.x backport to release/v5.1.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants