Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add max-metadata check for credit class and credit batch #540

Merged
merged 5 commits into from
Sep 16, 2021

Conversation

aleem1314
Copy link
Contributor

@aleem1314 aleem1314 commented Sep 15, 2021

Description

Closes: #520


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented Sep 15, 2021

Codecov Report

Merging #540 (8554f3a) into master (cbc060a) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 8554f3a differs from pull request most recent head d0bcc11. Consider uploading reports for the commit d0bcc11 to get more accurate results

@@            Coverage Diff             @@
##           master     #540      +/-   ##
==========================================
- Coverage   77.45%   77.44%   -0.01%     
==========================================
  Files         100      100              
  Lines       12760    12765       +5     
==========================================
+ Hits         9883     9886       +3     
- Misses       2287     2288       +1     
- Partials      590      591       +1     
Flag Coverage Δ
experimental-codecov 77.44% <100.00%> (-0.01%) ⬇️
stable-codecov 68.22% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@aleem1314 aleem1314 marked this pull request as ready for review September 16, 2021 08:45
Copy link
Contributor

@technicallyty technicallyty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@ryanchristo ryanchristo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@ryanchristo ryanchristo enabled auto-merge (squash) September 16, 2021 16:11
@ryanchristo ryanchristo merged commit 744489e into master Sep 16, 2021
@ryanchristo ryanchristo deleted the aleem/520-metadata-length branch September 16, 2021 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add MaxMetadataLength for credit class & credit batch metdata
3 participants