Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ValidateDenom for MsgSend, MsgRetire, and MsgCancel #554

Merged
merged 7 commits into from
Sep 29, 2021

Conversation

aleem1314
Copy link
Contributor

@aleem1314 aleem1314 commented Sep 22, 2021

Description

Closes: #551


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented Sep 22, 2021

Codecov Report

Merging #554 (5dc114c) into master (f7c2cb8) will decrease coverage by 0.11%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #554      +/-   ##
==========================================
- Coverage   76.06%   75.94%   -0.12%     
==========================================
  Files         105      105              
  Lines       13831    13829       -2     
==========================================
- Hits        10520    10502      -18     
- Misses       2699     2709      +10     
- Partials      612      618       +6     
Flag Coverage Δ
experimental-codecov 75.94% <100.00%> (-0.12%) ⬇️
stable-codecov 67.30% <100.00%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@aleem1314 aleem1314 marked this pull request as ready for review September 22, 2021 13:22
Copy link
Member

@ryanchristo ryanchristo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@aleem1314 aleem1314 enabled auto-merge (squash) September 23, 2021 15:03
x/ecocredit/client/testsuite/tx.go Outdated Show resolved Hide resolved
@ryanchristo ryanchristo merged commit 6d17f39 into master Sep 29, 2021
@ryanchristo ryanchristo deleted the aleem/551-validate-denom branch September 29, 2021 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ValidateDenom for MsgSend, MsgRetire, and MsgCancel
6 participants