docs(x/ecocredit): clarify EventReceive.sender

[aaronc]

Description

Closes: #XXXX

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title
• added ! to the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• followed the guidelines for building modules
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• included comments for documenting Go code
• updated the relevant documentation or specification
• reviewed "Files changed" and left comments if necessary
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed ! in the type prefix if API or client breaking change
• confirmed all author checklist items have been addressed
• reviewed state machine logic
• reviewed API design and naming
• reviewed documentation is accurate
• reviewed tests and test coverage
• manually tested (if applicable)

[codecov]

Codecov Report

Merging #778 (ec745a7) into master (b8cd057) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #778      +/-   ##
==========================================
- Coverage   40.28%   40.25%   -0.04%     
==========================================
  Files         124      124              
  Lines       37215    37215              
==========================================
- Hits        14993    14981      -12     
- Misses      21250    21266      +16     
+ Partials      972      968       -4     

Flag	Coverage Δ
experimental-codecov	40.21% <ø> (-0.04%)	⬇️
stable-codecov	34.36% <ø> (+0.02%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

[technicallyty]

would it be useful to have an enum distinguishing the sender type? I assume we'd put the basket denom in sender, but maybe consumers would want the enum so they know what to do with the string in sender?

[aaronc]

could you make that update @technicallyty ? although I'd say let's not overload sender, but instead add basket_denom. We don't want consumers to choke on a denom instead of address in sender

[technicallyty]

done, and ran proto-gen

[aaronc]

let's not do any proto breakage here please. this is already in production. basket_denom should be 6

[technicallyty]

fixed

[aaronc]

need another review here

[aaronc]

This needs to be backported (manually) and Take needs to be updated

[robert-zaremba]

Why we didn't generate gogo? I think we need gogo.

[technicallyty]

Why we didn't generate gogo? I think we need gogo.

looks like theres a namespacing issue. We have multiple events.proto files who's go_package points to x/ecocredit. So the changes made here are being generated, but being overwritten by the other events.proto.

i suggest we subpackage these so proto/regen/ecocredit/v1alpha1 would generate into -> x/ecocredit/v1alpha1/