Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(x/data): add data module to stable app config #887

Merged
merged 4 commits into from
Mar 15, 2022

Conversation

aleem1314
Copy link
Contributor

@aleem1314 aleem1314 commented Mar 15, 2022

Description

Closes: #881


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented Mar 15, 2022

Codecov Report

Merging #887 (83fc992) into master (888f8a5) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 83fc992 differs from pull request most recent head b55e432. Consider uploading reports for the commit b55e432 to get more accurate results

@@            Coverage Diff             @@
##           master     #887      +/-   ##
==========================================
- Coverage   74.02%   74.01%   -0.02%     
==========================================
  Files         171      171              
  Lines       22115    22118       +3     
==========================================
  Hits        16371    16371              
- Misses       4631     4634       +3     
  Partials     1113     1113              
Flag Coverage Δ
experimental-codecov 73.98% <100.00%> (-0.02%) ⬇️
stable-codecov 67.16% <100.00%> (+0.57%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@aleem1314 aleem1314 marked this pull request as ready for review March 15, 2022 15:35
Copy link
Member

@ryanchristo ryanchristo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Excited to have this in the stable config!

@ryanchristo ryanchristo enabled auto-merge (squash) March 15, 2022 17:33
@ryanchristo ryanchristo merged commit 9819ea5 into master Mar 15, 2022
@ryanchristo ryanchristo deleted the aleem/881-data-module branch March 15, 2022 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add data module to stable app config
3 participants