Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ecocredit/core): query batches by issuer #955

Merged
merged 3 commits into from
Mar 31, 2022

Conversation

technicallyty
Copy link
Contributor

@technicallyty technicallyty commented Mar 30, 2022

Description

  • adds issuer field to BatchInfo table
  • adds issuer index to BatchInfo table
  • adds query by issuer for batches

Closes: #167


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented Mar 30, 2022

Codecov Report

Merging #955 (e060e1d) into master (90af8c3) will decrease coverage by 0.15%.
The diff coverage is 54.54%.

@@            Coverage Diff             @@
##           master     #955      +/-   ##
==========================================
- Coverage   73.08%   72.92%   -0.16%     
==========================================
  Files         197      197              
  Lines       23196    23192       -4     
==========================================
- Hits        16952    16913      -39     
- Misses       4952     4992      +40     
+ Partials     1292     1287       -5     
Flag Coverage Δ
experimental-codecov 72.92% <54.54%> (-0.05%) ⬇️
stable-codecov ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@ryanchristo ryanchristo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Comment on lines +120 to +121
// issuer is the address that issued the batch
bytes issuer = 2;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reference, this was removed during the project updates and will not require a state migration to add the field as the it currently exists in the v1alpha1 version live on mainnet and redwood.

@ryanchristo ryanchristo enabled auto-merge (squash) March 31, 2022 20:24
@ryanchristo ryanchristo merged commit 9e41e6a into master Mar 31, 2022
@ryanchristo ryanchristo deleted the ty/167-batches_by_issuer branch March 31, 2022 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add additional indexes and queries to x/ecocredit module
3 participants