Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix file rename following merge #2024

Merged
merged 1 commit into from
Aug 14, 2023
Merged

Conversation

ryanchristo
Copy link
Member

@ryanchristo ryanchristo commented Aug 14, 2023

Description

Following #2002, new files were not properly renamed when merging. This fixes that. The build action is now required as well, which is why this was overlooked (the button was not disabled and the pull request was merged before CI finished).


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • provided a link to the relevant issue or specification
  • provided instructions on how to test
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

How to test

  1. CI build passes (currently failing on dev)

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items
.

I have...

  • confirmed all author checklist items have been addressed
  • reviewed code correctness and readability
  • verified React components follow DRY principles
  • reviewed documentation is accurate
  • reviewed tests
  • manually tested (if applicable)

@netlify
Copy link

netlify bot commented Aug 14, 2023

Deploy Preview for regen-website ready!

Name Link
🔨 Latest commit 66c8507
🔍 Latest deploy log https://app.netlify.com/sites/regen-website/deploys/64daaaea25d8b1000887ca8f
😎 Deploy Preview https://deploy-preview-2024--regen-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ryanchristo ryanchristo marked this pull request as ready for review August 14, 2023 22:41
@ryanchristo ryanchristo merged commit eafd5e5 into dev Aug 14, 2023
17 checks passed
@ryanchristo ryanchristo deleted the ryan/2022-fix-merge branch August 14, 2023 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants