Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: not found page #2032

Merged
merged 2 commits into from
Aug 21, 2023
Merged

fix: not found page #2032

merged 2 commits into from
Aug 21, 2023

Conversation

ryanchristo
Copy link
Member

@ryanchristo ryanchristo commented Aug 17, 2023

Description

Closes: #2020

This pull request adds a 404.tsx file with a Custom404 function as instructed in the nextjs documentation that renders the existing NotFound component view.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • provided a link to the relevant issue or specification
  • provided instructions on how to test
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

How to test

  1. https://deploy-preview-2032--regen-website.netlify.app/foo

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items
.

I have...

  • confirmed all author checklist items have been addressed
  • reviewed code correctness and readability
  • verified React components follow DRY principles
  • reviewed documentation is accurate
  • reviewed tests
  • manually tested (if applicable)

@netlify
Copy link

netlify bot commented Aug 17, 2023

Deploy Preview for regen-website ready!

Name Link
🔨 Latest commit 31c4a5d
🔍 Latest deploy log https://app.netlify.com/sites/regen-website/deploys/64de67feb3a98f0008c3b48f
😎 Deploy Preview https://deploy-preview-2032--regen-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ryanchristo ryanchristo marked this pull request as ready for review August 17, 2023 18:33
@ryanchristo ryanchristo requested a review from a team August 17, 2023 18:33
@ryanchristo ryanchristo changed the title fix: add missing not found page fix: not found page Aug 17, 2023
@ryanchristo ryanchristo merged commit 7899354 into dev Aug 21, 2023
17 checks passed
@ryanchristo ryanchristo deleted the ryan/2020-not-found-page branch August 21, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

404 page for web-www not rendering properly
3 participants