Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unable to load project with initial metadata #2043

Merged
merged 3 commits into from
Aug 24, 2023

Conversation

ryanchristo
Copy link
Member

@ryanchristo ryanchristo commented Aug 24, 2023

Description

Closes: #2040

The issue with the project creation workflow was the result of an error when compacting project metadata without a context that included the proper references to schema and regen. This was producing the following error:

Screenshot from 2023-08-23 17-53-51

This is resolved by adding schema and regen to the context before compacting in the event no context is provided.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • provided a link to the relevant issue or specification
  • provided instructions on how to test
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

How to test

  1. Go to https://deploy-preview-2043--regen-website.netlify.app/ecocredits/portfolio
  2. Log in with an account that is an allowed issuer for a credit class
  3. Click the create new project button and select a credit class
  4. Fill out basic info and click "Save & Next"

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items
.

I have...

  • confirmed all author checklist items have been addressed
  • reviewed code correctness and readability
  • verified React components follow DRY principles
  • reviewed documentation is accurate
  • reviewed tests
  • manually tested (if applicable)

@netlify
Copy link

netlify bot commented Aug 24, 2023

Deploy Preview for regen-website ready!

Name Link
🔨 Latest commit 2c4add6
🔍 Latest deploy log https://app.netlify.com/sites/regen-website/deploys/64e770a3ca03be000879797f
😎 Deploy Preview https://deploy-preview-2043--regen-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ryanchristo ryanchristo requested a review from a team August 24, 2023 02:32
@ryanchristo ryanchristo marked this pull request as ready for review August 24, 2023 03:00
Copy link
Collaborator

@flagrede flagrede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@ryanchristo ryanchristo merged commit 2ff7495 into dev Aug 24, 2023
17 checks passed
@ryanchristo ryanchristo deleted the ryan/2039-fix-create-project branch August 24, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Project creation not working and resulting in 404 page
2 participants