Use raw strings for flake8 #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Before merging this, we should make sure we have a test that covers that function. Is this breaking anything? |
ralphbean
force-pushed
the
flake8-weirdness
branch
from
140e625
to
0d9ceb2
Compare
|
OK, I confirmed that zero tests cover this function - which means this is risky. I'll write some tests that pass on the old code first, and then confirm they work on the new code. |
flake8 was choking on these lines.
ralphbean
force-pushed
the
flake8-weirdness
branch
from
0d9ceb2
to
15d91d4
Compare
|
OK, I feel better about it now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flake8 was choking on these lines.