Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

Typescript support #5

Closed
SalahAdDin opened this issue Jun 12, 2021 · 4 comments · Fixed by #6
Closed

Typescript support #5

SalahAdDin opened this issue Jun 12, 2021 · 4 comments · Fixed by #6
Labels
☂️ area/types This affects typings good first issue 👋 This may be a great place to get started! help wanted 🙏 This could use your insight or help 🦋 type/enhancement This is great to have

Comments

@SalahAdDin
Copy link
Contributor

SalahAdDin commented Jun 12, 2021 •
edited
Loading

Subject of the feature

This package lacks to Typescript support despite react-markdown already offers support for it,

Problem

We are trying to migrate our current portffolio from Javascript to Typscript component by component and we found the next issue related to this package:

<html>TS7016: Could not find a declaration file for module 'remark-unwrap-images'. '/home/luisalaguna/Projects/portfolio/frontend2.0/node_modules/remark-unwrap-images/index.js' implicitly has an 'any' type.<br/>Try `npm i --save-dev @types/remark-unwrap-images` if it exists or add a new declaration (.d.ts) file containing `declare module 'remark-unwrap-images';`

Expected behavior

It should have a minimal typscript support.

Alternatives

As this is a very specifical plugin, it has no other alternative.
@SalahAdDin SalahAdDin added 🙉 open/needs-info This needs some more info 🦋 type/enhancement This is great to have labels Jun 12, 2021
@wooorm
Copy link
Member

wooorm commented Jun 12, 2021

It’s a warning. Not an error. Everything’s fine.

If you do want to add support for TS, see the most recent discussion issue and corresponding PR!

@wooorm wooorm closed this as completed Jun 12, 2021
@wooorm wooorm added good first issue 👋 This may be a great place to get started! help wanted 🙏 This could use your insight or help ☂️ area/types This affects typings and removed 🙉 open/needs-info This needs some more info labels Jun 12, 2021
@SalahAdDin
Copy link
Contributor Author

@wooorm I'm pretty sure this is not just a warn, it is a bug:
image

@ChristianMurphy
Copy link
Member

@SalahAdDin it is a warning, and can be ignored with // @ts-ignore
Or if you don't want to ignore the warning, you could open a PR adding typing as @wooorm suggests.

@SalahAdDin
Copy link
Contributor Author

@SalahAdDin it is a warning, and can be ignored with // @ts-ignore
Or if you don't want to ignore the warning, you could open a PR adding typing as @wooorm suggests.

Ok, let me do that tomorrow.

Thank you.

@SalahAdDin SalahAdDin mentioned this issue Jun 12, 2021
Merged
wooorm pushed a commit that referenced this issue Jun 13, 2021
@SalahAdDin
Add types
1a1b24b 
Closes GH-5.
Closes GH-6.

Reviewed-by: Christian Murphy <christian.murphy.42@gmail.com>
Reviewed-by: Titus Wormer <tituswormer@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
☂️ area/types This affects typings good first issue 👋 This may be a great place to get started! help wanted 🙏 This could use your insight or help 🦋 type/enhancement This is great to have
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add types SalahAdDin/remark-unwrap-images
3 participants
@wooorm @ChristianMurphy @SalahAdDin