Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add typescript types #20

Closed
roshcagra opened this issue Sep 30, 2020 · 1 comment · Fixed by #21
Closed

Add typescript types #20

roshcagra opened this issue Sep 30, 2020 · 1 comment · Fixed by #21
Labels
☂️ area/types This affects typings 🧑 semver/major This is a change 🦋 type/enhancement This is great to have

Comments

@roshcagra
Copy link

Subject of the feature

Typescript support

Problem

No typing support for this module :(
@roshcagra roshcagra added 🙉 open/needs-info This needs some more info 🦋 type/enhancement This is great to have labels Sep 30, 2020
@ChristianMurphy
Copy link
Member

@roshcagra pull requests are welcome!
You can find some examples of other typings to base these typings off of:
remarkjs/remark-breaks#1
remarkjs/remark-frontmatter#12
remarkjs/remark-rehype#13
remarkjs/remark-html#32

@ChristianMurphy ChristianMurphy added ☂️ area/types This affects typings 🦋 type/enhancement This is great to have 🧑 semver/major This is a change and removed 🙉 open/needs-info This needs some more info 🦋 type/enhancement This is great to have labels Sep 30, 2020
@stefanprobst stefanprobst mentioned this issue Oct 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
☂️ area/types This affects typings 🧑 semver/major This is a change 🦋 type/enhancement This is great to have
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add types stefanprobst/strip-markdown
2 participants
@roshcagra @ChristianMurphy