-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add types #21
Merged
Merged
feat: add types #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanprobst
commented
Oct 11, 2020
This comment has been minimized.
This comment has been minimized.
wooorm
reviewed
Oct 12, 2020
ChristianMurphy
approved these changes
Oct 12, 2020
ChristianMurphy
approved these changes
Oct 12, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @stefanprobst! 🙇
hi, just checking if there is anything missing from my side? |
Could you resolve the conflict (should be possible on the GH UI)? |
done, thanks! |
wooorm
approved these changes
Oct 18, 2020
wooorm
added
☂️ area/types
This affects typings
⛵️ status/released
🦋 type/enhancement
This is great to have
🧑 semver/major
This is a change
labels
Oct 18, 2020
Released! thanks! |
This was referenced May 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
☂️ area/types
This affects typings
💪 phase/solved
Post is done
🧑 semver/major
This is a change
🦋 type/enhancement
This is great to have
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add types to
strip-markdown
closes #20