Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade guide to v6 should mention needed history update #8232

Closed
bthorben opened this issue Nov 5, 2021 · 2 comments
Closed

Upgrade guide to v6 should mention needed history update #8232

bthorben opened this issue Nov 5, 2021 · 2 comments

Comments

@bthorben
Copy link

bthorben commented Nov 5, 2021

I have just upgraded from v5 to v6 and got stuck using version 4.x of history. It would be nice to mention to upgrade to history 5.x in the upgrade guide.
@devinjameson
Copy link

How did you fix the history issue? I'm seeing a Could not resolve "history" error, is that the error you had as well?

@timdorr timdorr closed this as completed in 706f837 Nov 5, 2021
@mjackson
Copy link
Member

mjackson commented Nov 5, 2021

History is now a direct dependency of the router, not a peer dep. You shouldn't be installing or directly using it with v6. Everywhere you used history.push() or history.replace() you can now use navigate(). I'll add some notes to the migration docs to make this more clear.

@mjackson mjackson reopened this Nov 5, 2021
mjackson pushed a commit that referenced this issue Nov 5, 2021
@timdorr @mjackson
Add a mention of upgrading history. Closes #8232
985368a
mjackson added a commit that referenced this issue Nov 5, 2021
@mjackson
Update note about removing history dependency
c6e9c06 
Fixes #8232
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mjackson @bthorben @devinjameson