Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(react-router): clean up useRoutes' RouterProvider detection #10389

Merged
merged 1 commit into from
Apr 24, 2023

Conversation

brophdawg11
Copy link
Contributor

@brophdawg11 brophdawg11 commented Apr 24, 2023

Quick follow up to #10374 to avoid relying on implicit detection of being inside a RouterProvider and move to an explicit param passed to a new internal useRoutesImpl hook.

@changeset-bot
Copy link

changeset-bot bot commented Apr 24, 2023

⚠️ No Changeset found

Latest commit: 006ab05

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@MichaelDeBoey MichaelDeBoey changed the title Clean up useRoutes RouterProvider detection refactor(react-router): clean up useRoutes' RouterProvider detection Apr 24, 2023
@brophdawg11 brophdawg11 merged commit 7110596 into dev Apr 24, 2023
@brophdawg11 brophdawg11 deleted the brophdawg11/useroutesimpl branch April 24, 2023 19:55
Copy link
Contributor

@jasikpark jasikpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jasikpark
Copy link
Contributor

oh lol late to the punch

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 6.11.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 6.11.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants