Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove internal discoverRoutes queue and make patch idempotent #11977

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

brophdawg11
Copy link
Contributor

@brophdawg11 brophdawg11 commented Sep 10, 2024

Removed this fifo queue because it was a bit overly restrictive and prevents use cases such as the one described in #11947. This can be implemented in user land if required (as Remix does).

Copy link

changeset-bot bot commented Sep 10, 2024

🦋 Changeset detected

Latest commit: 60949a7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@remix-run/router Patch
react-router Patch
react-router-dom Patch
react-router-dom-v5-compat Patch
react-router-native Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@brophdawg11 brophdawg11 merged commit 2dd13c6 into v6 Sep 10, 2024
3 checks passed
@brophdawg11 brophdawg11 deleted the brophdawg11/remove-fow-fifo-queue branch September 10, 2024 16:43
Copy link
Contributor

github-actions bot commented Oct 9, 2024

🤖 Hello there,

We just published version 6.27.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant