Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native Quick Start, Link Documentation, and Examples #4678

Merged
merged 4 commits into from
Mar 10, 2017

Conversation

tylermcginnis
Copy link
Contributor

No description provided.

@@ -1,3 +1,3 @@
# <Prompt>

TODO
Re-exported from core [`Prompt`](../../../react-router/docs/api/Prompt.md)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ryanflorence Can you confirm this is right? It's how all the other files were but it wasn't importing correctly for me. I'm assuming there's some build step I wasn't running.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@mjackson mjackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for the PR @tylermcginnis

## Exponent

Easiest way to get started is probably with Exponent.
If this is your first time building a React Native app, we recommend you check out the official ["Getting Started"](https://facebook.github.io/react-native/docs/getting-started.html) guide.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@@ -1,6 +1,6 @@
import { AppRegistry } from 'react-native'

import App from './examples/BoringExample'
import App from './examples/BasicExample'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😂

@@ -1,3 +1,3 @@
# <Prompt>

TODO
Re-exported from core [`Prompt`](../../../react-router/docs/api/Prompt.md)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ryanflorence ryanflorence merged commit 8aa21a2 into remix-run:v4 Mar 10, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants