New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add repository directory for all packages.json [skip ci] #8124

Merged

timdorr merged 1 commit into remix-run:main from iamandrewluca:package-json-repository-directory

Oct 12, 2021

iamandrewluca commented Oct 11, 2021

If the package.json for your package is not in the root directory (for example if it is part of a monorepo), you can specify the directory in which it lives:
"repository": {
  "type" : "git",
  "url" : "https://github.com/facebook/react.git",
  "directory": "packages/react-dom"
}
— https://docs.npmjs.com/cli/v6/configuring-npm/package-json#repository

I use a lot https://njt.vercel.app/ to jump to different packages information,
and with this PR we can know exactly what package in what folder lives

Made the changes with a script to make it easier 🙂

https://gist.github.com/iamandrewluca/5cc85b56a595056f0099d04ed6dd8a79


          chore: add repository directory for all packages.json [skip ci]

7bde0b5

> If the package.json for your package is not in the root directory (for example if it is part of a monorepo), you can specify the directory in which it lives:
> ```json
> "repository": {
>   "type" : "git",
>   "url" : "https://github.com/facebook/react.git",
>   "directory": "packages/react-dom"
> }
> ```
> — https://docs.npmjs.com/cli/v6/configuring-npm/package-json#repository

I use a lot https://njt.vercel.app/ to jump to different packages information,
and with this PR we can know exactly what package in what folder lives

Made the changes with a script to make it easier 🙂

https://gist.github.com/iamandrewluca/5cc85b56a595056f0099d04ed6dd8a79

Member

timdorr commented Oct 12, 2021

While I like those shorthand repo fields, I can see this being more useful. Thanks!

timdorr merged commit 320be7a into remix-run:main

iamandrewluca deleted the package-json-repository-directory branch

October 12, 2021 08:45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet