feat: allow Link's "to" prop to accept external urls #9900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Logan McAnsh <logan@mcan.sh>
🦋 Changeset detectedLatest commit: 30e9e3e The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
2 tasks
jenseng
reviewed
Jan 13, 2023
|
very cool, though it looks like i'll want to deprecate |
Signed-off-by: Logan McAnsh <logan@mcan.sh>
brophdawg11
reviewed
Jan 16, 2023
brophdawg11
reviewed
Jan 17, 2023
Signed-off-by: Logan McAnsh <logan@mcan.sh>
Signed-off-by: Logan McAnsh <logan@mcan.sh>
Signed-off-by: Logan McAnsh <logan@mcan.sh>
brophdawg11
approved these changes
Jan 18, 2023
Signed-off-by: Logan McAnsh <logan@mcan.sh>
This was referenced Jan 24, 2023
yan12125
added a commit
to yan12125/buildbot
that referenced
this pull request
Aug 5, 2024
Somehow <Link> forces relative links and breaks external URLs (ex: https://buildbot.buildbot.net/#/about/http://buildbot.net). It might be fixed with react-router 6.7.1 [1], while I prefer to just use basic `<a>`. While I'm at it, I also updated the link to use HTTPS. [1] remix-run/react-router#9900
yan12125
added a commit
to yan12125/buildbot
that referenced
this pull request
Aug 5, 2024
Somehow <Link> forces relative links and breaks external URLs (ex: https://buildbot.buildbot.net/#/about/http://buildbot.net). It might be fixed with react-router 6.7.1 [1], while I prefer to just use basic `<a>`. While I'm at it, I also updated the link to use HTTPS. [1] remix-run/react-router#9900
3 tasks
mifo123
pushed a commit
to mifo123/buildbot
that referenced
this pull request
Aug 16, 2024
Somehow <Link> forces relative links and breaks external URLs (ex: https://buildbot.buildbot.net/#/about/http://buildbot.net). It might be fixed with react-router 6.7.1 [1], while I prefer to just use basic `<a>`. While I'm at it, I also updated the link to use HTTPS. [1] remix-run/react-router#9900
mokibit
pushed a commit
to mokibit/buildbot
that referenced
this pull request
Aug 25, 2024
Somehow <Link> forces relative links and breaks external URLs (ex: https://buildbot.buildbot.net/#/about/http://buildbot.net). It might be fixed with react-router 6.7.1 [1], while I prefer to just use basic `<a>`. While I'm at it, I also updated the link to use HTTPS. [1] remix-run/react-router#9900
mokibit
pushed a commit
to mokibit/buildbot
that referenced
this pull request
Aug 26, 2024
Somehow <Link> forces relative links and breaks external URLs (ex: https://buildbot.buildbot.net/#/about/http://buildbot.net). It might be fixed with react-router 6.7.1 [1], while I prefer to just use basic `<a>`. While I'm at it, I also updated the link to use HTTPS. [1] remix-run/react-router#9900
mokibit
pushed a commit
to mokibit/buildbot
that referenced
this pull request
Aug 26, 2024
Somehow <Link> forces relative links and breaks external URLs (ex: https://buildbot.buildbot.net/#/about/http://buildbot.net). It might be fixed with react-router 6.7.1 [1], while I prefer to just use basic `<a>`. While I'm at it, I also updated the link to use HTTPS. [1] remix-run/react-router#9900
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
complimentary work for remix-run/remix#5016
Signed-off-by: Logan McAnsh logan@mcan.sh