-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Full app crash if prop spread is before key inside loop #4080
Comments
I had the same problem in 1.7.0, I observed conflicting import symbols in the build target, and for now I had to rewrite the import to get around the error. source:
target:
Bypass this problem:
|
Thanks for the workaround @FlatMapIO also experienced this when upgrading a grunge stack to v 1.7 |
can confirm, I had a few spreads before the key was defined, moving the key to the start of the element fixed this error for me
vs
|
@JeffBeltran thanks for the workaround, it worked here too |
I can also confirm the issue and the workaround worked. |
I got a random error updating patch-version packages. Turns out this was the culprit. Thanks! |
Seems to have been fixed upstream in esbuild evanw/esbuild#2534 |
Wow, gnarly bug. Just ran into this. What made it especially difficult is that the crash occurs at |
Also just ran into this issue. Weird one for sure. |
Also run into that bug today. |
fixed by #4301 and released in https://github.com/remix-run/remix/releases/tag/remix%401.8.0 |
Oh wow, thanks for this!! I had no idea what I'd done that was causing this. |
What version of Remix are you using?
1.7.0
Steps to Reproduce
Reproduction is available: https://github.com/Swapnull/remix-spread-key-error/blob/main/app/routes/index.tsx
After upgrading from 1.6.5 to 1.7.0, When calling a component in a map while spreading props, the spread must be after the
key
, otherwise aElement type is invalid: expected a string...
error will happen.For example
Video of me demonstrating the issue: https://www.loom.com/share/1b8923577ae84e1e93f41be75b12cf77
Expected Behavior
It should not matter what order props appear in.
Actual Behavior
My large (150 route) remix app is breaking when upgrading to 1.7.0
The text was updated successfully, but these errors were encountered: