Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove useTransition in favor of useNavigation #5689

Merged
merged 10 commits into from
Mar 13, 2023
Merged

Remove useTransition in favor of useNavigation #5689

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
d93bc45
Remove useTransition from remix-react
brophdawg11 Mar 7, 2023
5f9aad0
Update tests
brophdawg11 Mar 7, 2023
9899188
Upate docs
brophdawg11 Mar 7, 2023
9723789
Keep integration tests and convert to useNavigation
brophdawg11 Mar 7, 2023
5d83470
Update E2E test for useTransition->useNavigation
brophdawg11 Mar 8, 2023
4141640
Remove unused imports
brophdawg11 Mar 8, 2023
074c116
Point to experimental RR version for Remix v2
brophdawg11 Mar 9, 2023
ccdb039
Add missing import
brophdawg11 Mar 10, 2023
2ec1f95
Add changeset
brophdawg11 Mar 10, 2023
654219f
Update changeset
brophdawg11 Mar 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update E2E test for useTransition->useNavigation
  • Loading branch information
@brophdawg11
brophdawg11 committed Mar 10, 2023
commit 5d834705bda79896059ec4c0d5e750c13ea53ef0
41 changes: 10 additions & 31 deletions integration/navigation-state-test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,10 +251,6 @@ test.describe("navigation states", () => {
hash: "",
state: {
_isRedirect: true,
// These were private API for transition manager that are no longer
// needed with the new router so OK to disappear
// setCookie: false,
// type: "loader",
},
key: expect.any(String),
},
Expand All @@ -275,19 +271,16 @@ test.describe("navigation states", () => {
expect(navigations).toEqual([
IDLE_STATE,
{
state: "submitting",
state: "loading",
location: {
pathname: `/${STATES.SUBMITTING_LOADER}`,
search: "?key=value",
hash: "",
state: null,
key: expect.any(String),
},
// Note: This is a bug in Remix but we're going to keep it that way
// in useTransition (including the back-compat version) and it'll be
// fixed with useNavigation
formMethod: "GET",
formAction: `/${STATES.SUBMITTING_LOADER}?key=value`,
formMethod: "get",
formAction: `/${STATES.SUBMITTING_LOADER}`,
formEncType: "application/x-www-form-urlencoded",
formData: expect.any(Object),
},
Expand All @@ -309,36 +302,31 @@ test.describe("navigation states", () => {
expect(navigations).toEqual([
IDLE_STATE,
{
state: "submitting",
state: "loading",
location: {
pathname: `/${STATES.SUBMITTING_LOADER_REDIRECT}`,
search: "",
hash: "",
state: null,
key: expect.any(String),
},
formMethod: "GET",
formMethod: "get",
formAction: `/${STATES.SUBMITTING_LOADER_REDIRECT}`,
formEncType: "application/x-www-form-urlencoded",
formData: expect.any(Object),
},
{
state: "loading",
type: "loaderSubmissionRedirect",
location: {
pathname: "/",
search: "?redirected",
hash: "",
state: {
_isRedirect: true,
// These were private API for transition manager that are no longer
// needed with the new router so OK to disappear
// setCookie: false,
// type: "loader",
},
key: expect.any(String),
},
formMethod: "GET",
formMethod: "get",
formAction: `/${STATES.SUBMITTING_LOADER_REDIRECT}`,
formEncType: "application/x-www-form-urlencoded",
formData: expect.any(Object),
Expand Down Expand Up @@ -367,7 +355,7 @@ test.describe("navigation states", () => {
state: null,
key: expect.any(String),
},
formMethod: "POST",
formMethod: "post",
formAction: `/${STATES.SUBMITTING_ACTION}`,
formEncType: "application/x-www-form-urlencoded",
formData: expect.any(Object),
Expand All @@ -381,7 +369,7 @@ test.describe("navigation states", () => {
state: null,
key: expect.any(String),
},
formMethod: "POST",
formMethod: "post",
formAction: `/${STATES.SUBMITTING_ACTION}`,
formEncType: "application/x-www-form-urlencoded",
formData: expect.any(Object),
Expand Down Expand Up @@ -412,7 +400,7 @@ test.describe("navigation states", () => {
state: null,
key: expect.any(String),
},
formMethod: "POST",
formMethod: "post",
formAction: `/${STATES.SUBMITTING_ACTION_REDIRECT}`,
formEncType: "application/x-www-form-urlencoded",
formData: expect.any(Object),
Expand All @@ -425,14 +413,10 @@ test.describe("navigation states", () => {
hash: "",
state: {
_isRedirect: true,
// These were private API for transition manager that are no longer
// needed with the new router so OK to disappear
// setCookie: false,
// type: "loader",
},
key: expect.any(String),
},
formMethod: "POST",
formMethod: "post",
formAction: `/${STATES.SUBMITTING_ACTION_REDIRECT}`,
formEncType: "application/x-www-form-urlencoded",
formData: expect.any(Object),
Expand Down Expand Up @@ -462,11 +446,6 @@ test.describe("navigation states", () => {
hash: "",
state: {
_isRedirect: true,
_isFetchActionRedirect: true,
// These were private API for transition manager that are no longer
// needed with the new router so OK to disappear
// setCookie: false,
// type: "loader",
},
key: expect.any(String),
},
Expand Down