Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: stop passing isTypeScript to remix.init script #7099

Conversation

MichaelDeBoey
Copy link
Member

Follow-up of @markdalgleish's #6887

@MichaelDeBoey MichaelDeBoey added package:create-remix package:dev BREAKING CHANGE This change will require a major version bump v2 Issues related to v2 apis labels Aug 7, 2023
@changeset-bot
Copy link

changeset-bot bot commented Aug 7, 2023

🦋 Changeset detected

Latest commit: 7eeb408

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
create-remix Major
@remix-run/dev Major
remix Major
@remix-run/architect Major
@remix-run/cloudflare Major
@remix-run/cloudflare-pages Major
@remix-run/cloudflare-workers Major
@remix-run/css-bundle Major
@remix-run/deno Major
@remix-run/eslint-config Major
@remix-run/express Major
@remix-run/node Major
@remix-run/react Major
@remix-run/serve Major
@remix-run/server-runtime Major
@remix-run/testing Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@markdalgleish
Copy link
Member

This was deliberately left in as a backwards compatibility layer for existing templates. If we do this, we might want to fast-follow the v2 release with some PRs to community templates that rely on this flag.

@MichaelDeBoey
Copy link
Member Author

@markdalgleish I'm happy to create PRs for our stacks + the official Netlify & Vercel templates (if needed)

I can also do the top 10 listed repos with remix-stack tag if wanted

@MichaelDeBoey MichaelDeBoey force-pushed the stop-passing-isTypeScript-to-remix-init-script branch from 4f8e5ec to 1275207 Compare August 8, 2023 17:09
@brophdawg11
Copy link
Contributor

IIRC we would prefer to remove remix init entirely eventually? Is there a large benefit to removing this flag? It sounds like it just creates a bunch more work for us (per #7099 (comment)) so curious if the the juice is worth the squeeze?

@MichaelDeBoey
Copy link
Member Author

Imo it makes it more clear to template/stack creators that we're not supporting JS transpilation anymore so that they have to provide a JS version themselves if they want to support that

@MichaelDeBoey MichaelDeBoey force-pushed the stop-passing-isTypeScript-to-remix-init-script branch 3 times, most recently from 0a9e7fe to 8545f0e Compare August 8, 2023 22:06
@markdalgleish
Copy link
Member

markdalgleish commented Aug 8, 2023

IIRC we would prefer to remove remix init entirely eventually? Is there a large benefit to removing this flag? It sounds like it just creates a bunch more work for us (per #7099 (comment)) so curious if the the juice is worth the squeeze?

I looked into removing it as part of the new create-remix work but found that it will take us more work to remove it than to keep it at the moment due to the way our stacks heavily rely on it. I ultimately felt that removing remix init would be a bunch of work (and churn for community templates) without much payoff. I'm still in favour of removing it if there's a good opportunity in the future though.

@MichaelDeBoey
Copy link
Member Author

I would say: the longer we keep it, more templates/stacks can start to rely on it, so more templates/stacks will need an update to remove it from their codebase

@brophdawg11
Copy link
Contributor

I'm on board with whatever you guys think - you've got more context than I do here - just want to avoid creating any unnecessary work :). I don't think updating the top 10 community stacks is totally necessary if we've got this clearly called out as a breaking change in v2, but if the LOE is small than it could be a nice addition.

@brophdawg11 brophdawg11 removed their request for review August 9, 2023 14:43
@MichaelDeBoey
Copy link
Member Author

Then I would just merge this one
@markdalgleish WDYT?

@MichaelDeBoey MichaelDeBoey force-pushed the stop-passing-isTypeScript-to-remix-init-script branch 2 times, most recently from b648947 to d8d92cb Compare August 9, 2023 23:15
@markdalgleish
Copy link
Member

Yep, let's merge it.

@MichaelDeBoey MichaelDeBoey force-pushed the stop-passing-isTypeScript-to-remix-init-script branch from dadade5 to 7eeb408 Compare August 10, 2023 00:01
@MichaelDeBoey MichaelDeBoey merged commit b1149bb into remix-run:dev Aug 10, 2023
9 checks passed
@MichaelDeBoey MichaelDeBoey deleted the stop-passing-isTypeScript-to-remix-init-script branch August 10, 2023 00:24
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-b1149bb-20230810 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BREAKING CHANGE This change will require a major version bump CLA Signed package:create-remix package:dev v2 Issues related to v2 apis
Projects
No open projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

3 participants