Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: align types with React Router #7319

Merged
merged 10 commits into from
Sep 6, 2023
Merged

feat!: align types with React Router #7319

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
77a8b65
Align types with React Router
brophdawg11 Aug 31, 2023
02f48a1
Fix lint issue
brophdawg11 Aug 31, 2023
a389baf
Update Remix types to use unknown instead of any
brophdawg11 Sep 5, 2023
0d781a9
Merge branch 'release-next' into brophdawg11/align-rr-types
brophdawg11 Sep 5, 2023
7ba1b38
Apply suggestions from code review
brophdawg11 Sep 5, 2023
5532a3d
Update exports
brophdawg11 Sep 5, 2023
f62989d
Switch fetcher to use AppData in generic
brophdawg11 Sep 5, 2023
339f2c5
Revert back to 20.5.1 for node CI runs
brophdawg11 Sep 6, 2023
35b6e1c
Switch `UIMatch` from `interface` to `type`
brophdawg11 Sep 6, 2023
41a1647
Bump RR prerelease
brophdawg11 Sep 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review 
Co-authored-by: Michaël De Boey <info@michaeldeboey.be>
  • Loading branch information
@brophdawg11 @MichaelDeBoey
brophdawg11 and MichaelDeBoey committed Sep 5, 2023
commit 7ba1b382160a2edda9dac235b01cefdf6aa48964
3 changes: 2 additions & 1 deletion .changeset/align-rr-types.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
"@remix-run/cloudflare": major
"@remix-run/deno": major
"@remix-run/node": major
"@remix-run/react": major
"@remix-run/server-runtime": major
brophdawg11 marked this conversation as resolved.
Show resolved Hide resolved
---

Expand All @@ -16,5 +17,5 @@ Remove/align Remix types with those used in React Router
* `useMatches()[i].handle` type changed from `{ [k: string]: any }` to `unknown`
* `AppLoadContext` type changed from `{ [k: string]: unknown }` to `unknown`
* Make `LoaderFunctionArgs`/`ActionFunctionArgs` generic to accept a `context` type
* Rename `LoaderFunction`/`ActionFunction` to `LoaderFunctionArgs`/`ActionFunctionArgs`
* Rename `LoaderArgs`/`ActionArgs` to `LoaderFunctionArgs`/`ActionFunctionArgs`
* Rename the `useMatches()` return type from `RouteMatch` to `UIMatch`
2 changes: 1 addition & 1 deletion packages/remix-react/components.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -982,7 +982,7 @@ export interface UIMatch<D = AppData> extends UIMatchRR<SerializeFrom<D>> {}
* Returns the active route matches, useful for accessing loaderData for
* parent/child routes or the route "handle" property
*
* @see https://remix.run/docs/hooks/use-matches
* @see https://remix.run/hooks/use-matches
*/
export function useMatches(): UIMatch[] {
return useMatchesRR() as UIMatch[];
Expand Down
Loading