Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(remix-dev/vite, server-runtime): pass Vite server errors to vite.ssrFixStacktrace #8066

Merged
merged 12 commits into from
Nov 24, 2023
Merged

fix(remix-dev/vite, server-runtime): pass Vite server errors to vite.ssrFixStacktrace #8066

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
1396b16
fix(vite): apply `ssrFixStacktrace` to server error
hi-ogawa Nov 20, 2023
5988807
Merge branch 'dev' into vite-ssrFixStacktrace
hi-ogawa Nov 20, 2023
25e865c
test: add test
hi-ogawa Nov 21, 2023
9b7b08f
chore: changeset
hi-ogawa Nov 21, 2023
4eb7194
Merge branch 'dev' into vite-ssrFixStacktrace
hi-ogawa Nov 22, 2023
22eae1a
Merge branch 'dev' into vite-ssrFixStacktrace
hi-ogawa Nov 23, 2023
cc9d5f9
refactor: add DevServerHooks.fixStackTrace
hi-ogawa Nov 23, 2023
6708f3e
chore: rename
hi-ogawa Nov 23, 2023
16022e4
Merge branch 'dev' into vite-ssrFixStacktrace
markdalgleish Nov 23, 2023
7b0dd6a
update changeset
markdalgleish Nov 24, 2023
6ded334
rename hook to processRequestError
markdalgleish Nov 24, 2023
09dcf0a
tweak test name
markdalgleish Nov 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
tweak test name
  • Loading branch information
@markdalgleish
markdalgleish committed Nov 24, 2023
commit 09dcf0aa885ed35b9e97e07bcaea0768d2d17e0f
2 changes: 1 addition & 1 deletion integration/vite-dev-test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,7 +418,7 @@ test.describe("Vite dev", () => {
expect(pageErrors).toEqual([]);
});

test("server error stacktrace", async ({ page }) => {
test("request errors map to original source code", async ({ page }) => {
let pageErrors: unknown[] = [];
page.on("pageerror", (error) => pageErrors.push(error));

Expand Down
Loading