Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change content type on single fetch requests #9889

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

brophdawg11
Copy link
Contributor

Closes #9884

Copy link

changeset-bot bot commented Aug 19, 2024

🦋 Changeset detected

Latest commit: 064db2c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@remix-run/server-runtime Patch
@remix-run/cloudflare Patch
@remix-run/deno Patch
@remix-run/dev Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/testing Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/architect Patch
@remix-run/express Patch
@remix-run/serve Patch
create-remix Patch
remix Patch
@remix-run/css-bundle Patch
@remix-run/eslint-config Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ivogt
Copy link
Contributor

ivogt commented Aug 19, 2024

Would you consider doing the same for defer? It has the same issue as single fetch.

@brophdawg11
Copy link
Contributor Author

I don't think defer needs updating because it's being deprecated and replaced with Single Fetch very soon. But beyond that, it's a stable API so one could argue changing the content type is a breaking change so we could not make that change in v2 anyway. You may be able to change it in userland via handleDataRequest though.

@brophdawg11 brophdawg11 merged commit dfa8120 into dev Aug 20, 2024
5 checks passed
@brophdawg11 brophdawg11 deleted the brophdawg11/single-fetch-content-type branch August 20, 2024 16:18
@github-actions github-actions bot added the awaiting release This issue has been fixed and will be released soon label Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting release This issue has been fixed and will be released soon feat:single-fetch package:server-runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants