Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically optimize dependencies of the client entry #9922

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Automatically optimize dependencies of the client entry #9922

merged 1 commit into from
Aug 30, 2024

Conversation

pcattori
Copy link
Contributor

Closes: #

  • Docs
  • Tests

Testing Strategy:

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 30, 2024

⚠️ No Changeset found

Latest commit: 6f04839

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pcattori pcattori merged commit 24d1b21 into dev Aug 30, 2024
9 checks passed
@pcattori pcattori deleted the pedro/optimize-deps-client-entry branch August 30, 2024 03:16
@github-actions github-actions bot added the awaiting release This issue has been fixed and will be released soon label Aug 30, 2024
markdalgleish
markdalgleish reviewed Sep 2, 2024
View reviewed changes
packages/remix-dev/vite/plugin.ts
path.join(ctx.remixConfig.appDirectory, route.file)
),
entries: [
ctx.entryClientFilePath,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following on from this comment: https://github.com/remix-run/remix/pull/9921/files#r1740220074

The client entry is already captured in the Rollup build options, so if that turns out to fix it, it'll cover this case too.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 5, 2024

🤖 Hello there,

We just published version 2.12.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 9, 2024

🤖 Hello there,

We just published version 2.12.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions github-actions bot removed the awaiting release This issue has been fixed and will be released soon label Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markdalgleish markdalgleish markdalgleish left review comments

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pcattori @markdalgleish